child_process: Check stderr before accessing it#9152
Closed
robertchiras wants to merge 1 commit intonodejs:v4.x-stagingfrom
Closed
child_process: Check stderr before accessing it#9152robertchiras wants to merge 1 commit intonodejs:v4.x-stagingfrom
robertchiras wants to merge 1 commit intonodejs:v4.x-stagingfrom
Conversation
nodejs-github-bot
added
child_process
4 tasks
Member
|
This needs to be rebased and updated. |
Contributor
|
ping @robertchiras re: rebase |
robertchiras
force-pushed
the
4.x-staging
branch
from
eabad4a to
fdb2408
Compare
Contributor
Author
|
I just did a rebase on v4.x-staging, but I don't see any update here. Can you tell me how can I update the pull request? |
If something bad happens in spawnSync, stderr might be null. Therefore, we have to check it before using it, so we won't mask the actual exception. PR-URL: nodejs#6877 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Contributor
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
If something bad happens in spawnSync, stderr might be null. Therefore, we have to check it before using it, so we won't mask the actual exception. Ref: #9152 PR-URL: #6877 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Contributor
|
All failures are infra related landed in 90e0573 |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
If something bad happens in spawnSync, stderr might be null. Therefore, we have to check it before using it, so we won't mask the actual exception. Ref: #9152 PR-URL: #6877 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
child_process
Description of change
If something bad happens in spawnSync, stderr might be null. Therefore,
we have to check it before using it, so we won't mask the actual
exception.
PR-URL: #6877
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Robert Jefe Lindstädt robert.lindstaedt@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: Jeremiah Senkpiel fishrock123@rocketmail.com